Welcome, Guest
Username: Password: Remember me
  • Page:
  • 1

TOPIC:

Possible improvement for OrderListAdd in XSharp.RDD 23 Mar 2023 09:47 #25746

  • stefan.ungemach
  • stefan.ungemach's Avatar
  • Topic Author


  • Posts: 14
  • A collegue of mine has pointed out an issue in OrderListAdd() / ADSIndex.prg:

    If the result of ACE.ADSOpenIndex() is ACE.AE_INDEX_ALREADY_OPEN (5065) in line 481 the logic checks all open indices against the desired one. If there is a hit self:Index is set correctly and the surrounding logic could proceed w/o problems.

    However since there ist still 5065 in result, SELF:_CheckError(result,EG_OPEN) in line 506 throws an error which leads to confusing protocols. Would it make sense to set result back to AE_SUCCESS in line 491 before exiting the fallback logic?

    I have attached a screenshot of our proposal (blue line). Feel free to comment :)
    Attachments:

    Please Log in or Create an account to join the conversation.

    Last edit: by robert.

    Possible improvement for OrderListAdd in XSharp.RDD 23 Mar 2023 12:28 #25747

    • robert
    • robert's Avatar


  • Posts: 3600
  • Stefan,

    Good catch!

    Robert
    XSharp Development Team
    The Netherlands

    Please Log in or Create an account to join the conversation.

    • Page:
    • 1